-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance during block volume re-encryption #3177
base: master
Are you sure you want to change the base?
Improve performance during block volume re-encryption #3177
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nikolay-andreev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @nikolay-andreev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
becac22
to
dde8ecf
Compare
Signed-off-by: Nikolay Andreev <[email protected]>
dde8ecf
to
bfa8f01
Compare
CSI should not invoke internal FCD API as FCD is an internal implementation detail of CNS. This also does not align with how we are building out the CNS stack and APIs . We should not merge this PR, so I'm putting a hold on this. /hold |
What this PR does / why we need it:
Volume re-encryption requires the current encryption status of the First-Class Disk (FCD) to apply the desired crypto spec. The encryption status is currently retrieved using the CNS API QueryVolumeInfo. This API returns much more information than necessary, resulting in a 4x performance penalty compared to retrieving the storage object directly.
Testing done:
API performance tests:
Iterations: 100
CnsQueryVolume: 27.15s
CnsQueryVolumeInfo: 109.26s
VslmRetrieveVStorageObject: 26.75s
Iterations: 1000
CnsQueryVolume: 274.38s
CnsQueryVolumeInfo: 1158.22s
VslmRetrieveVStorageObject: 259.36s
Special notes for your reviewer:
Release note: