Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance during block volume re-encryption #3177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikolay-andreev
Copy link
Contributor

What this PR does / why we need it:
Volume re-encryption requires the current encryption status of the First-Class Disk (FCD) to apply the desired crypto spec. The encryption status is currently retrieved using the CNS API QueryVolumeInfo. This API returns much more information than necessary, resulting in a 4x performance penalty compared to retrieving the storage object directly.

Testing done:
API performance tests:

Iterations: 100
CnsQueryVolume: 27.15s
CnsQueryVolumeInfo: 109.26s
VslmRetrieveVStorageObject: 26.75s

Iterations: 1000
CnsQueryVolume: 274.38s
CnsQueryVolumeInfo: 1158.22s
VslmRetrieveVStorageObject: 259.36s

Special notes for your reviewer:

Release note:

Copy link

linux-foundation-easycla bot commented Jan 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nikolay-andreev / name: Nikolay Andreev (bfa8f01)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikolay-andreev
Once this PR has been reviewed and has the lgtm label, please assign shalini-b for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nikolay-andreev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2025
@nikolay-andreev nikolay-andreev force-pushed the volume-encryption-perf-optimize branch from becac22 to dde8ecf Compare January 28, 2025 12:11
@nikolay-andreev nikolay-andreev force-pushed the volume-encryption-perf-optimize branch from dde8ecf to bfa8f01 Compare January 28, 2025 12:23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 28, 2025
@SandeepPissay
Copy link
Contributor

CSI should not invoke internal FCD API as FCD is an internal implementation detail of CNS. This also does not align with how we are building out the CNS stack and APIs . We should not merge this PR, so I'm putting a hold on this.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants