Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wip) fix flaky unit tests #3118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adikul30
Copy link
Contributor

@adikul30 adikul30 commented Nov 21, 2024

What this PR does / why we need it:

#3083 introduced a goroutine for restarting the container after a specified amount of time in case listview is not up and session is valid.

This PR prevents running this goroutine during unit tests as it's not required for unit tests and can cause some flakiness.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged.
The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc.
For new features, new tests should be done, in addition to regression tests.
If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject.
The review cycle will start, only after "[WIP]" is removed from the PR subject.

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adikul30

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@adikul30
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Nov 21, 2024
@adikul30
Copy link
Contributor Author

/retest

@adikul30
Copy link
Contributor Author

/retest pull-vsphere-csi-driver-unit-test

@k8s-ci-robot
Copy link
Contributor

@adikul30: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-vsphere-csi-driver-build
  • /test pull-vsphere-csi-driver-unit-test
  • /test pull-vsphere-csi-driver-verify-fmt
  • /test pull-vsphere-csi-driver-verify-golangci-lint
  • /test pull-vsphere-csi-driver-verify-markdown
  • /test pull-vsphere-csi-driver-verify-shell
  • /test pull-vsphere-csi-driver-verify-staticcheck
  • /test pull-vsphere-csi-driver-verify-vet

Use /test all to run the following jobs that were automatically triggered:

  • pull-vsphere-csi-driver-build
  • pull-vsphere-csi-driver-unit-test
  • pull-vsphere-csi-driver-verify-fmt
  • pull-vsphere-csi-driver-verify-golangci-lint
  • pull-vsphere-csi-driver-verify-staticcheck
  • pull-vsphere-csi-driver-verify-vet

In response to this:

/retest pull-vsphere-csi-driver-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adikul30
Copy link
Contributor Author

/test pull-vsphere-csi-driver-unit-test

@adikul30
Copy link
Contributor Author

cc: @chethanv28

@adikul30
Copy link
Contributor Author

/test pull-vsphere-csi-driver-unit-test

@adikul30 adikul30 force-pushed the topic/aditya/fix-flaky-unit-test branch from 079613d to 918f5c4 Compare November 21, 2024 22:23
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2024
@adikul30
Copy link
Contributor Author

/test pull-vsphere-csi-driver-unit-test

@k8s-ci-robot
Copy link
Contributor

@adikul30: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-vsphere-csi-driver-unit-test 918f5c4 link true /test pull-vsphere-csi-driver-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants