-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build multi-arch docker image #5730
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @harryzcy! |
Hi @harryzcy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @harryzcy
Thanks for your contribution!
I think looks like this build job will be failed.
Could you check my comment?
@@ -9,14 +9,25 @@ steps: | |||
- "PROJECT_ID=$PROJECT_ID" | |||
- "_GIT_TAG=$_GIT_TAG" | |||
- "_PULL_BASE_REF=$_PULL_BASE_REF" | |||
# We need to use bash to configure the build date and version properly. | |||
# We need to use bash to configure the build date and version properly. | |||
- name: "gcr.io/cloud-builders/docker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe ""gcr.io/cloud-builders/docker"
image does not contain buildx
plugin.
https://github.com/GoogleCloudPlatform/cloud-builders/blob/7b3987f0b23841ce782cf6547ab89ce2996ce983/docker/Dockerfile-versioned#L5-L9
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harryzcy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello there, @harryzcy! It's been some time since this PR was reviewed and changes were requested. Since no action was taken since the last review on Jul 15, I will be closing it. If you are still interested in contributing these changes, please don't hesitate to reopen the PR. /close |
@koba1t: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Close #5729