[Refactor] Move image to internal

[varshaprasad96]

This PR is an effort towards reducing the public surface of APIs. It move image/ to internal/image

Signed-off-by: Varsha Prasad Narsing [email protected]
(cherry picked from commit 1f5890709fdc17de6f44f42b5138dd0f7e64bc74)

[koba1t]

/assign

[koba1t]

@varshaprasad96

This PR looks almost good!

But I think it looks like imageTagUpdater struct is only called in the imagetag package, So Could we move this struct to an internal package?
If you have any other opinions, please tell me!

[varshaprasad96]

@koba1t I was looking into it. imageTagUpdater is being used in Filter (

kustomize/api/filters/imagetag/imagetag.go

Line 52 in 7c36ed2

SetValue: imageTagUpdater{

) which is a public API - more as a helper. Since the imageTagUpdater is itself not exported, we need not worry about its public support. It can be used only inside filters pkg/ as we need it in future in case we want to expand. Which is why I'm hesitant on moving it away from imagetag pkg, to have all the related code in one place. What do you think?

[koba1t]

imageTagUpdater is being used in Filter

Sorry, I couldn't find it.
I agree with your concerns and I think you don't have to move the imageTagUpdater struct.
Thanks for checking the details!

/lgtm

[koba1t]

/cc @annasong20 @natasha41575

[natasha41575]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment