Simplify collection of SubjectAlternativeNames for apiserver #12507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
VannTen
force-pushed
the
cleanup/sans_apiserver
branch
from
49411d1 to
4bda02d
Compare
Remove a bunch of intermediate variables, which fixes a "'UndefinedMarker' concatenation" error in ansible-lint v25.8.1.
VannTen
force-pushed
the
cleanup/sans_apiserver
branch
from
4bda02d to
7c5909a
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
This appear to work but I'd rather hold it until after 2.29 so it gets more testing in master before a release |
k8s-ci-robot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Remove a bunch of intermediate variables, which fixes a
"'UndefinedMarker' concatenation" error in ansible-lint v25.8.1.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Related: #12484
I'm not completely sure this works so just putting this as draft for now
Does this PR introduce a user-facing change?: