-
Notifications
You must be signed in to change notification settings - Fork 6.7k
CI: Try a full ssh connection on hosts instead of only checking the port #12416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
8eaf3e9
to
11b32d1
Compare
If this worked, #12359 can fixed |
This does not work yet, because for some reason
|
If we only try the port, we can try to connect in the playbook which is executed next even though the managed node has not yet completed it's boot-up sequence ("System is booting up. Unprivileged users are not permitted to log in yet. Please come back later. For technical details, see pam_nologin(8).") wait_for_connection works, but we need to take care to exclude errors which are not 'unreachable' (in particular, python-less hosts would failed that task, but only after ssh succeded).
e9b6bcb
to
a228ffa
Compare
What type of PR is this?
/kind flake
What this PR does / why we need it:
If we only try the port, we can try to connect in the playbook which is
executed next even though the managed node has not yet completed it's
boot-up sequence ("System is booting up. Unprivileged users are not
permitted to log in yet. Please come back later. For technical details,
see pam_nologin(8).")
wait_for_connection works, but we need to take care to exclude errors
which are not 'unreachable' (in particular, python-less hosts would
failed that task, but only after ssh succeded).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
See and example of the problem : https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/10754918165 (look for 'System is booting up')
Does this PR introduce a user-facing change?: