-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: (helm/v1alpha1): add missing replicas field to the Deployment generated #4356
🐛 fix: (helm/v1alpha1): add missing replicas field to the Deployment generated #4356
Conversation
Hi @monteiro-renato. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
27421f7
to
db6764d
Compare
pkg/plugins/optional/helm/v1alpha/scaffolds/internal/templates/values.go
Outdated
Show resolved
Hide resolved
db6764d
to
45925f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catcher 🥇
Thank you a lot for your help on those
/lgtm
/approve
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, monteiro-renato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've also moved the field out of "container" since I find it to be a bit less confusing from a k8s concepts point of view.