🌱 Make make remove-spaces compatible with GNU and MAC OS X system

[damsien]

Why this PR does exist

This PR is motivated by this issue: #4327.

It is a fix about the make remove-spaces command that was only working on OS X and not GNU based system. It is because the behavior of the sed -i command is different between these two systems (see this stack exchange discussion).

• On OS X: sed -i ''
• On GNU: sed -i

So I added a check by using uname to use the sed -i in the correct way depending if we are on GNU based system or on OS X based system.

This PR follows this one #4330 that was not working. So it got reverted here #4331. This PR should works correctly. I cannot test on a MAC since I only have a linux system.

This PR needs to be tested by someone that has a MAC before merging.

Quick explanation

The bash -c is used because make cannot interpret if & else since it executes each line of the recipe in a separate shell (each command runs in isolation, making the condition ineffective).

Then we check only for "Linux" system and not "Darwin". Why? Because we want the default behavior of the command to be the same as previously (the command that worked for the "Darwin" system).
Thus, if it is a GNU system (uname = Linux), then we execute the modified command. Else, we execute the default behavior -> the previous command.

[k8s-ci-robot]

Hi @damsien. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damsien]

@camilamacedo86 Can you please test this one on your system? 😄

[camilamacedo86]

Thank you 🥇
I tested locally for mac os and worked

/lgtm
/approved
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, damsien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Hi @damsien

You need rebase this branch with master for we are able to move forward
Could you please do that?

[damsien]

Hi @camilamacedo86 , thank you for your test
I just rebased

[camilamacedo86]

/lgtm

[damsien]

/retest