Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add windows support to tools-releases #2984

Conversation

codablock
Copy link

This PR adds support for Windows builds in tools-releases, so that these can be used via setup-envtest. If this is merged, it will require enabling it in the GCP Cloud Build (I have no experience with that part).

I'm currently using the branch behind this PR in https://github.com/kluctl/kubebuilder-tools-releases-windows, which simply clones my kubebuilder fork, checks out the tools-releases-windows branch and manually runs the Docker build for the Windows release. I do this to trick setup-envtest into accepting the downloaded binaries when invoking it with -i, which will then later allow me to simply drop the manual downloading. You can find all this here: https://github.com/kluctl/kluctl/blob/main/Makefile#L60.

When this PR gets merged and GCP Cloud Build is updated as well, I will then be able to remove the manual downloading and simply rely on setup-envtest.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @codablock!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @codablock. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2022
@camilamacedo86
Copy link
Member

/ok-to-test

I am ok with us adding this one. But is important to highlight that Kubebuilder itself does not support windows besides that be desired, see: #2940

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2022
@camilamacedo86
Copy link
Member

/approved

@camilamacedo86
Copy link
Member

@jmrodri and @varshaprasad96 wdyt?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2022
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
@varshaprasad96
Copy link
Member

Agreed with @camilamacedo86, it would be nice to explicitly mention in docs that Kubebuilder has not been tested against Windows and its upto the developer to do so.
We could add this to docs in a follow up too. Else it looks good!

Thanks for the contribution @codablock!
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, codablock, jmrodri, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,jmrodri,varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d63a7cd into kubernetes-sigs:tools-releases Oct 5, 2022
@codablock
Copy link
Author

Thanks for the review and merge :)
I assume that the GCP Cloud Build needs to be configured to actually activate the new build? Looking into https://storage.googleapis.com/kubebuilder-tools, I can not see the new build yet.

@camilamacedo86
Copy link
Member

Hi @codablock,

Yes, we will need to enable it into the Google Cloud, see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/RELEASE.md#to-build-the-kubebuilder-tools-artifacts-required-to-use-env-test

I change my email and we need help here from others to re-enable our access there. So, asap we will add it. You can follow up: #3005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants