🌱 Add v1beta2 RollingOut condition #11463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/conditions
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XL
chrischdi
reviewed
Nov 21, 2024
api/v1beta1/cluster_types.go
Outdated
| ClusterRollingOutV1Beta2Condition = RollingOutV1Beta2Condition | ||
|
|
||
| // ClusterRollingOutV1Beta2Reason surfaces when at least one of the Cluster's control plane, MachineDeployments, | ||
| // and MachinePools are rolling out. |
There was a problem hiding this comment.
Suggested change
| // and MachinePools are rolling out. | |
| // or MachinePools are rolling out. |
api/v1beta1/cluster_types.go
Outdated
| ClusterRollingOutV1Beta2Reason = RollingOutV1Beta2Reason | ||
|
|
||
| // ClusterNotRollingOutV1Beta2Reason surfaces when none of the Cluster's control plane, MachineDeployments, | ||
| // and MachinePools are rolling out. |
There was a problem hiding this comment.
Suggested change
| // and MachinePools are rolling out. | |
| // or MachinePools are rolling out. |
api/v1beta1/cluster_types.go
Outdated
| ClusterNotRollingOutV1Beta2Reason = NotRollingOutV1Beta2Reason | ||
|
|
||
| // ClusterRollingOutUnknownV1Beta2Reason surfaces when one of the Cluster's control plane, MachineDeployments, | ||
| // and MachinePools rolling out condition is unknown, and none true. |
There was a problem hiding this comment.
Suggested change
| // and MachinePools rolling out condition is unknown, and none true. | |
| // or MachinePools rolling out condition is unknown, and none true. |
| @@ -148,6 +148,21 @@ const ( | |||
| MachineDeploymentMachinesUpToDateInternalErrorV1Beta2Reason = InternalErrorV1Beta2Reason | |||
| ) | |||
|
|
|||
| // MachineDeployment's RollingOut condition and corresponding reasons that will be used in v1Beta2 API version. | |||
| const ( | |||
| // MachineDeploymentRollingOutV1Beta2Condition is true if there is at least one machine not up-to-date. | |||
There was a problem hiding this comment.
Suggested change
| // MachineDeploymentRollingOutV1Beta2Condition is true if there is at least one machine not up-to-date. | |
| // MachineDeploymentRollingOutV1Beta2Condition is true if there is at least one machine not up-to-date. |
| // MachineDeploymentRollingOutV1Beta2Condition is true if there is at least one machine not up-to-date. | ||
| MachineDeploymentRollingOutV1Beta2Condition = RollingOutV1Beta2Condition | ||
|
|
||
| // MachineDeploymentRollingOutV1Beta2Reason surfaces when there is at least one machine not up-to-date. |
There was a problem hiding this comment.
Suggested change
| // MachineDeploymentRollingOutV1Beta2Reason surfaces when there is at least one machine not up-to-date. | |
| // MachineDeploymentRollingOutV1Beta2Reason surfaces when there is at least one machine not up-to-date. |
| @@ -210,6 +211,63 @@ func setInitializedCondition(_ context.Context, kcp *controlplanev1.KubeadmContr | |||
| }) | |||
| } | |||
|
|
|||
| func setRollingOutCondition(_ context.Context, kcp *controlplanev1.KubeadmControlPlane, machines collections.Machines) { | |||
| // Count machines rolling out and collect reasons why a rollout is happening. | |||
| // Note: We collects all reasons for which at least a machine is rolling out; under normal circumstances | |||
There was a problem hiding this comment.
Suggested change
| // Note: We collects all reasons for which at least a machine is rolling out; under normal circumstances | |
| // Note: We collect all reasons for which at least a machine is rolling out; under normal circumstances |
| }, | ||
| }, | ||
| { | ||
| name: "one up-to-date, two not up-to-date, onr reporting up-to-date unknown", |
There was a problem hiding this comment.
Suggested change
| name: "one up-to-date, two not up-to-date, onr reporting up-to-date unknown", | |
| name: "one up-to-date, two not up-to-date, one reporting up-to-date unknown", |
| }, | ||
| }, | ||
| { | ||
| name: "one up-to-date, two not up-to-date, onr reporting up-to-date unknown", |
There was a problem hiding this comment.
Suggested change
| name: "one up-to-date, two not up-to-date, onr reporting up-to-date unknown", | |
| name: "one up-to-date, two not up-to-date, one reporting up-to-date unknown", |
fabriziopandini
force-pushed
the
add-v1beta2-rollout-condition
branch
from
51a3573
to
3fb816d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Part of #11105
/area conditions