🌱 Refine v1beta2 stale deletion messages #11434
Merged
+341
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/conditions
k8s-ci-robot
added
the
size/L
sbueringer
reviewed
Nov 19, 2024
internal/controllers/machinedeployment/machinedeployment_status.go
Outdated
Show resolved
Hide resolved
internal/controllers/machineset/machineset_controller_status.go
Outdated
Show resolved
Hide resolved
|
/lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e8bab6562779b57b713dd722746a5eb850dc677e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
force-pushed
the
refine-v1beta2-stale-deletion-messages
branch
from
01a9e46
to
14430e0
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improve messages for stale machines and makes them consistent across conditions
Note: this PR does not tackle the issue of code duplication that we already have for some func we are using when computing conditions
/area conditions
Part of #11105