Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 e2e: bump to ubuntu-2404-kube-v1.31.2 #2267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 e2e: bump to ubuntu-2404-kube-v1.31.2 #2267

wants to merge 1 commit into from
+5 −5

Conversation

EmilienM
Copy link
Contributor

What this PR does / why we need it:

Let's bump k8s release to v1.31.2 to align with other platforms
and the k8s version of CAPI & CAPO.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from emilienm. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 2fc382e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/673f8137c231ce0008c07e4d
😎 Deploy Preview https://deploy-preview-2267--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90
lentzi90 reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just jumped to 24.04 without pointing it out 🙈

test/e2e/data/e2e_conf.yaml Outdated Show resolved Hide resolved
test/e2e/data/e2e_conf.yaml Outdated Show resolved Hide resolved
test/e2e/data/e2e_conf.yaml Outdated Show resolved Hide resolved
@EmilienM @lentzi90
e2e: bump to ubuntu-2404-kube-v1.31.2
2fc382e 
Let's bump k8s release to v1.31.2 to align with other platforms
and the k8s version of CAPI & CAPO.

Co-authored-by: Lennart Jern <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2024
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90
lentzi90 reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I hope the tests agree 🤞
We should bump the version for flatcar also. I forgot about that image. Will build it tomorrow.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@lentzi90
Copy link
Contributor

cluster-api-provider-openstack/test/e2e/shared/images.go

Line 82 in 7518781

ArtifactPath: "ubuntu/2024-05-28/" + e2eCtx.E2EConfig.GetVariable("OPENSTACK_IMAGE_NAME") + ".img",

Ouch. We should make this configurable. I'm planning to work on this to fix #2243 when I have the time

@k8s-ci-robot
Copy link
Contributor

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-full-test 2fc382e link false /test pull-cluster-api-provider-openstack-e2e-full-test
pull-cluster-api-provider-openstack-e2e-test 2fc382e link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@lentzi90 lentzi90

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
CAPO Roadmap
Status: Inbox
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilienM @k8s-ci-robot @lentzi90