Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Align cluster-template.yaml and cluster-template-flatcar.yaml #5157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Align cluster-template.yaml and cluster-template-flatcar.yaml #5157

wants to merge 1 commit into from

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Oct 15, 2024 •
edited
Loading

What type of PR is this?

/kind support

What this PR does / why we need it:

This moves, quotes and formats YAML to make the diff between the two templates close to zero. ClusterRole/ebs-csi-node and permissions for ClusterRole/cloud-controller-manager are added.

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andidog. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2024
damdo
damdo reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@damdo
Copy link
Member

damdo commented Oct 15, 2024

/assign @nrb @richardcase @dlipovetsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@luthermonson luthermonson Awaiting requested review from luthermonson

@nrb nrb Awaiting requested review from nrb

Assignees

@richardcase richardcase

@nrb nrb

@dlipovetsky dlipovetsky

@damdo damdo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndiDog @k8s-ci-robot @damdo @richardcase @nrb @dlipovetsky