Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix cloud-controller-manager ClusterRole's service account permissions in templates #5156

Merged

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Oct 15, 2024

What type of PR is this?

/kind support

What this PR does / why we need it:

Aligns this template with the others which already have the working permissions set.

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2024
@richardcase
Copy link
Member

/cherrypick release-2.6

@k8s-infra-cherrypick-robot

@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
@AndiDog AndiDog force-pushed the clusterrole-template-permission branch from e1ce153 to db08cb9 Compare October 15, 2024 09:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@AndiDog
Copy link
Contributor Author

AndiDog commented Oct 15, 2024

/retitle Fix cloud-controller-manager ClusterRole's service account permissions in templates

Sorry, I found that another commit of mine did the same on another file. Force-pushed so both files get patched.

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Fix cloud-controller-manager ClusterRole's service account permissions in machine pool template Fix cloud-controller-manager ClusterRole's service account permissions in templates Oct 15, 2024
@AndiDog
Copy link
Contributor Author

AndiDog commented Oct 15, 2024

/retitle 🌱 Fix cloud-controller-manager ClusterRole's service account permissions in templates

@k8s-ci-robot k8s-ci-robot changed the title Fix cloud-controller-manager ClusterRole's service account permissions in templates 🌱 Fix cloud-controller-manager ClusterRole's service account permissions in templates Oct 15, 2024
@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c277fc into kubernetes-sigs:main Oct 15, 2024
23 of 24 checks passed
@k8s-infra-cherrypick-robot

@richardcase: #5156 failed to apply on top of branch "release-2.6":

Applying: Fix cloud-controller-manager ClusterRole's service account permissions in templates
Using index info to reconstruct a base tree...
M	templates/cluster-template-machinepool.yaml
M	templates/cluster-template.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/cluster-template.yaml
CONFLICT (content): Merge conflict in templates/cluster-template.yaml
Auto-merging templates/cluster-template-machinepool.yaml
CONFLICT (content): Merge conflict in templates/cluster-template-machinepool.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix cloud-controller-manager ClusterRole's service account permissions in templates

In response to this:

/cherrypick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants