Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s.io dependencies to v0.27.2 #629

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

ash2k
Copy link
Member

@ash2k ash2k commented Aug 9, 2023

Based on and contains commits from #619.

@k8s-ci-robot k8s-ci-robot requested review from mortent and seans3 August 9, 2023 02:56
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 9, 2023
@ash2k ash2k mentioned this pull request Aug 9, 2023
@ash2k ash2k force-pushed the update-dependencies branch from 0516acf to df48a70 Compare August 9, 2023 03:04
@ash2k ash2k force-pushed the update-dependencies branch from df48a70 to 8964a66 Compare August 9, 2023 03:32
@ash2k ash2k changed the title Update k8s.io dependencies to v0.27.4 Update k8s.io dependencies to v0.27.2 Aug 9, 2023
@ash2k
Copy link
Member Author

ash2k commented Aug 9, 2023

We actually cannot update to the v0.27.3 or v0.27.4 without stepping into the mess of kubernetes/kubernetes#118340. We'll have to go directly to v0.28.x.

@ash2k
Copy link
Member Author

ash2k commented Aug 9, 2023

@seans3 @mortent This passes CI, finally.

Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for the clean-up

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ash2k, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0b156cb into kubernetes-sigs:master Aug 9, 2023
@seans3
Copy link
Contributor

seans3 commented Aug 9, 2023

Also addresses: kubernetes/kubernetes#119840

@ash2k ash2k deleted the update-dependencies branch August 9, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants