Skip to content

Commit

Permalink
fix warnings when build images (#282)
Browse files Browse the repository at this point in the history
fix warnings when build images
```
 1 warning found (use docker --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 2)
```
and
```
 => WARN: LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format (line 5)                                                                           0.0s
 => WARN: LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format (line 6)                                                                           0.0s
 => WARN: LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format (line 8)  
```
  • Loading branch information
k8s-ci-robot authored Oct 1, 2024
2 parents eb2c973 + 10f69d8 commit 1c1c149
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
7 changes: 4 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
# ------------------------------------------------------------------------------

# IMAGES used when running tests.
BLIXT_CONTROLPLANE_IMAGE ?= ghcr.io/kubernetes-sigs/blixt-controlplane
BLIXT_DATAPLANE_IMAGE ?= ghcr.io/kubernetes-sigs/blixt-dataplane
BLIXT_UDP_SERVER_IMAGE ?= ghcr.io/kubernetes-sigs/blixt-udp-test-server
REGISTRY ?= ghcr.io/kubernetes-sigs
BLIXT_CONTROLPLANE_IMAGE ?= $(REGISTRY)/blixt-controlplane
BLIXT_DATAPLANE_IMAGE ?= $(REGISTRY)/blixt-dataplane
BLIXT_UDP_SERVER_IMAGE ?= $(REGISTRY)/blixt-udp-test-server

# Dockerfile paths for each service
CONTROLPLANE_DOCKERFILE ?= build/Containerfile.controlplane
Expand Down
2 changes: 1 addition & 1 deletion build/Containerfile.dataplane
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM rust:1.75-slim-bookworm as builder
FROM rust:1.75-slim-bookworm AS builder

ARG TARGETARCH

Expand Down
4 changes: 2 additions & 2 deletions build/Containerfile.udp_server
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM rust as builder
FROM rust AS builder

RUN apt-get update && \
apt-get install musl-tools -yq && \
Expand All @@ -25,7 +25,7 @@ RUN --mount=type=cache,target=/workspace/target/ \

FROM alpine

LABEL org.opencontainers.image.source https://github.com/kubernetes-sigs/blixt
LABEL org.opencontainers.image.source=https://github.com/kubernetes-sigs/blixt

WORKDIR /

Expand Down
2 changes: 1 addition & 1 deletion tools/performance/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM alpine

LABEL org.opencontainers.image.source https://github.com/kubernetes-sigs/blixt
LABEL org.opencontainers.image.source=https://github.com/kubernetes-sigs/blixt

RUN apk --no-cache add iperf3

Expand Down

0 comments on commit 1c1c149

Please sign in to comment.