-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in helm chart add proxy settings as secret #1499
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Hanzlik, Robert (MONETA) <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rubroboletus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @rubroboletus! |
Hi @rubroboletus. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Hanzlik, Robert (MONETA) <[email protected]>
Is this a bug fix or adding new feature?
New feature, implementing #1497
What is this PR about? / Why do we need it?
Leaking proxy credentials in open form in deployment env variables is not safe. Set them from a secret.
What testing is done?
Tested in our environment.