Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cluster-backup): add apis for managing backup storage location #7108

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(cluster-backup): add apis for managing backup storage location #7108

wants to merge 10 commits into from
+3,769 −10

Conversation

rajaSahil
Copy link

@rajaSahil rajaSahil commented Jan 29, 2025 •
edited by ahmedwaleedmalik
Loading

What this PR does / why we need it:
Introduce API endpoints for managing Backup Storage Locations in a user cluster. These API endpoints are used to manage BSLs for the functionality/feature of importing external cluster backups.

The following endpoints have been introduced:

  • CREATE BSL in the user cluster
  • GET a specific BSL
  • LIST all the available BSLs against a user cluster
  • DELETE a BSL specified by the name

Which issue(s) this PR fixes:

xref #7008

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add API endpoints for managing Backup Storage Locations in the user clusters

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. sig/api Denotes a PR or issue as being assigned to SIG API. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 29, 2025
@rajaSahil rajaSahil force-pushed the add-bsl-apis branch 4 times, most recently from 98e472a to 88e4677 Compare January 29, 2025 22:22
@Waseem826
Copy link
Contributor

/hold
I had a discussion with @rajaSahil and he'll update the PR.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2025
@rajaSahil rajaSahil force-pushed the add-bsl-apis branch 4 times, most recently from ec1f5b2 to 61ce3c4 Compare January 30, 2025 17:49
@rajaSahil rajaSahil requested a review from Waseem826 January 30, 2025 18:02
ahmedwaleedmalik
ahmedwaleedmalik requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a proper description for your PR and reference the GitHub ticket against which you are making these changes.

modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/storage-location/provider.go Outdated Show resolved Hide resolved
modules/api/pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 31, 2025
@rajaSahil rajaSahil force-pushed the add-bsl-apis branch 6 times, most recently from 0bee321 to 6712bcd Compare February 2, 2025 18:03
ahmedwaleedmalik
ahmedwaleedmalik requested changes Feb 3, 2025
View reviewed changes
modules/api/pkg/handler/v2/routes_v2.go Show resolved Hide resolved
modules/api/pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
@Waseem826 Waseem826 mentioned this pull request Feb 6, 2025
Open
ahmedwaleedmalik
ahmedwaleedmalik requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only re-reviewed the validation for the user. Everything else i'll review later.

modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
modules/api/pkg/ee/clusterbackup/backupstoragelocation/handler.go Outdated Show resolved Hide resolved
@ahmedwaleedmalik ahmedwaleedmalik force-pushed the add-bsl-apis branch 2 times, most recently from 0217c1a to f0f5987 Compare February 10, 2025 06:40
@ahmedwaleedmalik
Copy link
Member

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@ahmedwaleedmalik
Rebase with main branch
58673b5 
Signed-off-by: Waleed Malik <[email protected]>
@rajaSahil
Copy link
Author

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b9e3218aee2d7c55641e744f602da39acafdcf8c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Feb 11, 2025
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Feb 11, 2025
@kubermatic-bot
Copy link
Contributor

@rajaSahil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-api-e2e 898f68c link unknown /test pre-dashboard-api-e2e

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Waseem826
Copy link
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@Waseem826 Waseem826 Awaiting requested review from Waseem826

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajaSahil @Waseem826 @ahmedwaleedmalik @kubermatic-bot