Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Training SDK 1.9.0 #2395

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Jan 21, 2025

Part of: #2169

I released kubeflow-training==1.9.0 SDK version: https://pypi.org/manage/project/kubeflow-training/release/1.9.0/

/assign @kubeflow/wg-training-leads @Electronic-Waste

Signed-off-by: Andrey Velichkevich <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12878316716

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12862562175: 0.0%
Covered Lines: 85
Relevant Lines: 85

💛 - Coveralls

@@ -33,7 +33,7 @@

setuptools.setup(
name="kubeflow-training",
Copy link
Member

@terrytangyuan terrytangyuan Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to resolve https://peps.python.org/pep-0625/?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, your point is wondering if we should rename to "kubeflow_training" or "kubeflowtraining"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it is fine to keep it for 1.9 SDK since in the Deprecation they say:

 Any source distributions already uploaded will remain in place as-is and do not need to be updated.

For the newer Kubeflow Trainer SDK, we will name it kubeflow.
Does it look good @tenzen-y @terrytangyuan ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold
for Yuan question.

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Electronic-Waste, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/hold cancel

@terrytangyuan
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 21, 2025
@google-oss-prow google-oss-prow bot merged commit 5170a36 into kubeflow:release-1.9 Jan 21, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants