-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Training SDK 1.9.0 #2395
Release Training SDK 1.9.0 #2395
Conversation
Signed-off-by: Andrey Velichkevich <[email protected]>
Pull Request Test Coverage Report for Build 12878316716Details
💛 - Coveralls |
@@ -33,7 +33,7 @@ | |||
|
|||
setuptools.setup( | |||
name="kubeflow-training", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to resolve https://peps.python.org/pep-0625/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, your point is wondering if we should rename to "kubeflow_training" or "kubeflowtraining"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it is fine to keep it for 1.9 SDK since in the Deprecation they say:
Any source distributions already uploaded will remain in place as-is and do not need to be updated.
For the newer Kubeflow Trainer SDK, we will name it kubeflow
.
Does it look good @tenzen-y @terrytangyuan ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
for Yuan question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Electronic-Waste, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/lgtm |
Part of: #2169
I released kubeflow-training==1.9.0 SDK version: https://pypi.org/manage/project/kubeflow-training/release/1.9.0/
/assign @kubeflow/wg-training-leads @Electronic-Waste