Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildx link was broken #2356

Merged
merged 1 commit into from
Dec 17, 2024
Merged

buildx link was broken #2356

merged 1 commit into from
Dec 17, 2024

Conversation

Veer0x1
Copy link
Contributor

@Veer0x1 Veer0x1 commented Dec 14, 2024

buildx comes by default with docker v23 and newer

What this PR does / why we need it:
BuildKit is the default Docker build engine, so both docker build and docker buildx build use BuildKit to build images. docker build is now an alias for the docker buildx build command.
BuildKit is the default builder for users on Docker Desktop and Docker Engine v23.0 and later.
https://docs.docker.com/build/buildkit/

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Balveer Singh Rao <[email protected]>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Veer0x1!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 69094e1 into kubeflow:master Dec 17, 2024
52 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12328680364

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12321746319: 0.0%
Covered Lines: 85
Relevant Lines: 85

💛 - Coveralls

LogicalGuy77 added a commit to LogicalGuy77/training-operator-lg that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants