Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go version to v1.23 #2302

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I upgraded the Go version to v1.23, and golangci-lint version to support the new Go version.
Furthermore, I fixed lint errors came from the later golanci-lint:

pkg/controller.v1/xgboost/xgboost.go:138:5: S1009: should omit nil check; len() for map[github.com/kubeflow/training-operator/pkg/apis/kubeflow.org/v1.ReplicaType]*github.com/kubeflow/training-operator/pkg/apis/kubeflow.org/v1.ReplicaSpec is defined as zero (gosimple)
        if job.Spec.XGBReplicaSpecs == nil || len(job.Spec.XGBReplicaSpecs) == 0 {
           ^
pkg/controller.v1/mpi/mpijob_controller.go:715:26: printf: non-constant format string in call to fmt.Errorf (govet)
                return nil, fmt.Errorf(msg)
                                       ^
[...]

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Oct 23, 2024

Pull Request Test Coverage Report for Build 12320818171

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on upgrade-go-version at 100.0%

Totals Coverage Status
Change from base Build 12320692734: 100.0%
Covered Lines: 85
Relevant Lines: 85

💛 - Coveralls

@tenzen-y
Copy link
Member Author

/assign @kubeflow/wg-training-leads
/assign @kuizhiqing

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tenzen-y!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0b8fb3e into kubeflow:master Dec 13, 2024
52 checks passed
@tenzen-y tenzen-y deleted the upgrade-go-version branch December 13, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants