[SDK] Adding env vars #2285
Merged
[SDK] Adding env vars #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarek Abouzeid <[email protected]> using same implementation in katib Signed-off-by: Tarek Abouzeid <[email protected]> updating docs Signed-off-by: Tarek Abouzeid <[email protected]>
Pull Request Test Coverage Report for Build 12480966961Details
💛 - Coveralls |
There was a problem hiding this comment.
Sorry for the delay @tarekabouzeid!
I think, this great feature we should contribute before we release Training Operator 1.9.
Please can you add the unit tests for it ?
Signed-off-by: Tarek Abouzeid <[email protected]>
Signed-off-by: Tarek Abouzeid <[email protected]>
Signed-off-by: Tarek Abouzeid <[email protected]>
There was a problem hiding this comment.
Thank you for this contribution @tarekabouzeid 🎉
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable users to set environment variables to init and worker containers. Used same implementation in Katib here
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2284
Checklist: