Skip to content

Commit

Permalink
Update manifest: adjust permissions, and format changes
Browse files Browse the repository at this point in the history
Signed-off-by: Xinmin Du <[email protected]>
  • Loading branch information
Xinmin Du committed Jan 10, 2025
1 parent 0140805 commit f908380
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 25 deletions.
31 changes: 8 additions & 23 deletions manifests/v2/overlays/kubeflow/kubeflow-training-roles.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ kind: ClusterRole
metadata:
name: kubeflow-training-admin-v2
labels:
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-admin: "true"
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-admin-v2: "true"
aggregationRule:
clusterRoleSelectors:
- matchLabels:
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-training-admin: "true"
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-training-admin-v2: "true"
rules: []

---
Expand All @@ -16,12 +16,14 @@ kind: ClusterRole
metadata:
name: kubeflow-training-edit-v2
labels:
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-edit: "true"
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-training-admin: "true"
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-edit-v2: "true"
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-training-admin-v2: "true"
rules:
- apiGroups:
- kubeflow.org
resources:
- clustertrainingruntimes
- trainingruntimes
- trainjobs
verbs:
- create
Expand All @@ -31,15 +33,6 @@ rules:
- patch
- update
- watch
- apiGroups:
- kubeflow.org
resources:
- clustertrainingruntimes
- trainingruntimes
verbs:
- get
- list
- watch
- apiGroups:
- kubeflow.org
resources:
Expand All @@ -56,22 +49,14 @@ rules:
- get
- list
- watch
- apiGroups:
- ""
resources:
- events
verbs:
- get
- list
- watch

---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: kubeflow-training-view-v2
labels:
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-view: "true"
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-view-v2: "true"
rules:
- apiGroups:
- kubeflow.org
Expand All @@ -88,4 +73,4 @@ rules:
resources:
- trainjobs/status
verbs:
- get
- get
9 changes: 7 additions & 2 deletions manifests/v2/overlays/kubeflow/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,13 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
resources:
- ../../base
- ../../base/crds
- ../../base/manager
- ../../base/rbac
- ../../base/webhook
- ../../base/runtimes/pre-training
- kubeflow-training-roles.yaml
# TODO (andreyvelich): JobSet should support kubeflow-system namespace.
- https://github.com/kubernetes-sigs/jobset/releases/download/v0.6.0/manifests.yaml
images:
- name: kubeflow/training-operator-v2
Expand All @@ -12,4 +17,4 @@ secretGenerator:
- name: training-operator-v2-webhook-cert
namespace: kubeflow-system
options:
disableNameSuffixHash: true
disableNameSuffixHash: true

0 comments on commit f908380

Please sign in to comment.