Skip to content

Conversation

@jeffspahr
Copy link
Contributor

Summary

Adds comprehensive unit tests for kubernetes client functions in k8s-helper.ts to improve test coverage ahead of the planned @kubernetes/client-node upgrade from 0.16.3 to 1.4.0.

Tests added for:

  • getPodLogs: success, default container, empty response, API errors
  • getPod: success, not found, invalid resource name validation
  • getConfigMap: success, not found, invalid resource name validation
  • listPodEvents: success, API errors, invalid resource name validation
  • getArgoWorkflow: namespace validation
  • getK8sSecret: base64 decoding, missing keys, empty data, API errors, namespace validation

Coverage improvement for k8s-helper.ts:

Metric Before After
Statements 72.66% 90.64%
Branches 54.23% 84.74%
Functions 68.42% 100%
Lines 71.54% 90.24%

Test plan

  • All 33 k8s-helper tests pass
  • All 153 server tests pass
  • Tests follow existing project patterns (jest.spyOn on TEST_ONLY exports)

Add comprehensive unit tests for kubernetes client functions to improve
test coverage ahead of @kubernetes/client-node upgrade from 0.16.3 to 1.4.0.

Tests added for:
- getPodLogs: success, default container, empty response, API errors
- getPod: success, not found, invalid resource name validation
- getConfigMap: success, not found, invalid resource name validation
- listPodEvents: success, API errors, invalid resource name validation
- getArgoWorkflow: namespace validation (requires k8s cluster for full tests)
- getK8sSecret: base64 decoding, missing keys, empty data, API errors

Coverage improvement for k8s-helper.ts:
- Statements: 72.66% → 90.64%
- Branches: 54.23% → 84.74%
- Functions: 68.42% → 100%
- Lines: 71.54% → 90.24%

Signed-off-by: Jeff Spahr <[email protected]>
@google-oss-prow
Copy link

Hi @jeffspahr. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

🎉 Welcome to the Kubeflow Pipelines repo! 🎉

Thanks for opening your first PR! We're excited to have you onboard 🚀

Next steps:

Feel free to ask questions in the comments.

@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Jan 10, 2026
@jeffspahr jeffspahr force-pushed the test/add-k8s-helper-tests branch from 3a58981 to 1bd89f8 Compare January 10, 2026 14:20
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/L and removed size/XL labels Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant