chore: Vars converted to replacements for manifests/kustomize/base/installs/generic #12632
+15
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
vikas-saxena02
changed the title
Author
|
/retest |
Signed-off-by: Vikas Saxena <[email protected]> repacing vars with replacemnts Signed-off-by: Vikas Saxena <[email protected]> updating config map to get rid of diff errors Signed-off-by: Vikas Saxena <[email protected]> deleteing params.yaml from generic dir Signed-off-by: Vikas Saxena <[email protected]>
vikas-saxena02
force-pushed
the
feature-kustomize-fix-base-generic
branch
from
d0fc302 to
7cbaa22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of kubeflow/manifests#2991, we are chaning all updating manifests to get rid of kustomize warnings. Given KFP is a big repo, so there will be multiple PRs for this. This is one of those many PRs.
Checklist: