-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(backend): remove usage of deprecated commonLabels in Kustomize manifests #11289
base: master
Are you sure you want to change the base?
Conversation
Hi @etheleon. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
resolves #11272 |
2ac97d1
to
2b40df0
Compare
running |
/verify-owners |
/ok-to-test |
@HumairAK could you approve the workflow runs? ty! |
manifests/kustomize/base/installs/generic/postgres/postgres-secret-extended.yaml
Outdated
Show resolved
Hide resolved
manifests/kustomize/env/platform-agnostic-multi-user-legacy/kustomization.yaml
Outdated
Show resolved
Hide resolved
manifests/kustomize/env/platform-agnostic-multi-user/kustomization.yaml
Outdated
Show resolved
Hide resolved
manifests/kustomize/env/platform-agnostic-tekton-multi-user/kustomization.yaml
Outdated
Show resolved
Hide resolved
hi @hbelmiro I've removed the redundant comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etheleon can you please sign-off your commits?
manifests/kustomize/env/platform-agnostic-tekton-multi-user/kustomization.yaml
Outdated
Show resolved
Hide resolved
/ok-to-test |
@etheleon did you had the chance to see my comments here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @etheleon.
You still need to sign off your commits.
Let me rebase and sign off thanks for reminding |
Used `kustomize edit fix --vars` Signed-off-by: etheleon <[email protected]>
2c5cee5
to
c53d0fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc @HumairAK
Description of your changes:
Removed commonLabels since it's deprecated in Kustomize's api/v0.16.0 release. In it's place labels and selectors should be mentioned explicitly in the resource.
Checklist: