Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of Catalog Service #725

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dhirajsb
Copy link
Contributor

Initial Version of Model Catalog Service

Description

Add a new Model Catalog service to model registry API. The API shares types with Model Registry service
to maximize the reuse of common properties.

How Has This Been Tested?

WIP

Merge criteria:

  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tarilabs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhirajsb dhirajsb force-pushed the model-catalog-service branch 2 times, most recently from da3cfea to f120c99 Compare January 22, 2025 15:08
@dhirajsb dhirajsb force-pushed the model-catalog-service branch from f120c99 to ea8b1a0 Compare January 22, 2025 15:10
@dhirajsb dhirajsb force-pushed the model-catalog-service branch from c858615 to 6f329e9 Compare January 22, 2025 21:03
@dhirajsb dhirajsb force-pushed the model-catalog-service branch from 098e54e to e27bc57 Compare January 24, 2025 21:20
Signed-off-by: Dhiraj Bokde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant