Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mysql version fix 8.0.3 -> 8.3.0 #703

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

dandawg
Copy link
Contributor

@dandawg dandawg commented Jan 15, 2025

Description

It Looks like the mysql:8.0.3 image version may have been a mistake, and it really should be mysql:8.3.0. I updated the mysql image version from 8.0.3 to 8.3.0 in the manifest file. This resolves three issues:

  1. The README suggest version 8.3.0 is being used in some notes near the bottom (see https://github.com/dandawg/model-registry#pull-image-rate-limiting), which is inconsistent with what is in the manifest (8.0.3) as is.
  2. The mysql:8.0.3 image results in ImagePullBackoff errors on Kind (at least on Mac). This can also be verified with docker pull mysql:8.0.3.
  3. The mysql:8.0.x versions are older (7 years old!) and have more vulnerabilities, so it will be better to use 8.3.0.

Note: this should fix issue #266

How Has This Been Tested?

Limited testing on Kind on Mac M2. Once I updated the version, the deployment was able to succeed. The rest of the model registry pods/services/deployments also came up without issue.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Daniel Dowler <[email protected]>
@dandawg
Copy link
Contributor Author

dandawg commented Jan 16, 2025

@rareddy @tarilabs I was just reading issue #266 and realized that this fixes that issue.

@tarilabs
Copy link
Member

tarilabs commented Feb 3, 2025

we are merging #267 , we can still account for this for the next KF MR release(S)

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rareddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f5b07f5 into kubeflow:main Feb 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants