add v2.0 demo with voiceover #540
Conversation
jesuino
left a comment
jesuino
left a comment
There was a problem hiding this comment.
The video looks great to me, thanks!
Would you please refer to it on README.md as well?
Thanks!
|
Thank you @jesuino, I have updated it! |
|
@jesuino I adjusted the file to be embedded in the ReadMe, but I had to compress it. Please let me know if it seems too low quality now. If it's ok, I'll delete the uploaded file |
ada333
left a comment
ada333
left a comment
There was a problem hiding this comment.
The video looks good to me, thanks!
|
@ederign this is ready when you are - I think it needs approval from someone in the new |
There was a problem hiding this comment.
@hmtosi the video is great! I just added a suggestion to upload it to youtube. If you start a thread on ML experience wg, I'm sure folks will be able to upload it to Kubeflow channel.
Also, you need to sign off on your git commits as part of the Kubeflow process (DCO failure).
Signed-off-by: Hannah Tosi <[email protected]>
hmtosi
force-pushed
the
issue-530-upload-demo
branch
from
6fd5f09 to
caa25bc
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
hmtosi
force-pushed
the
issue-530-upload-demo
branch
from
50ca956 to
c761f5e
Compare
|
@ederign thank you for your review! The video has been uploaded to youtube, and I made your suggested changes to the README. I have also signed off on all commits on this PR. Please approve if all looks good, or let me know if more changes are needed! |
Signed-off-by: Hannah Tosi <[email protected]>
Signed-off-by: Hannah Tosi <[email protected]>
Signed-off-by: Hannah Tosi <[email protected]>
Signed-off-by: Hannah Tosi <[email protected]>
Co-authored-by: Eder Ignatowicz <[email protected]> Signed-off-by: Hannah Tosi <[email protected]>
hmtosi
force-pushed
the
issue-530-upload-demo
branch
from
c761f5e to
954d17c
Compare
Signed-off-by: Hannah Tosi <[email protected]>
Signed-off-by: Hannah Tosi <[email protected]>
hmtosi
force-pushed
the
issue-530-upload-demo
branch
from
954d17c to
18ad655
Compare
…b that it's not durable Signed-off-by: Eder Ignatowicz <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hmtosi thank you so much for the cool video! Btw, I made a slight tweak to the thumbnail to make sure we are not using GitHub assets (which aren't durable). |
* add v2.0 demo with voiceover Signed-off-by: Hannah Tosi <[email protected]> * Update README.md Signed-off-by: Hannah Tosi <[email protected]> * Update README.md Signed-off-by: Hannah Tosi <[email protected]> * Delete Kale v2.0 Demo.mp4 Signed-off-by: Hannah Tosi <[email protected]> * Remove embedded ReadMe, test sign-off Signed-off-by: Hannah Tosi <[email protected]> * Update README.md Co-authored-by: Eder Ignatowicz <[email protected]> Signed-off-by: Hannah Tosi <[email protected]> * embed youtube video Signed-off-by: Hannah Tosi <[email protected]> * fix formatting Signed-off-by: Hannah Tosi <[email protected]> * fixing thumbnail src for a youtube link (instead of assets from github that it's not durable Signed-off-by: Eder Ignatowicz <[email protected]> --------- Signed-off-by: Hannah Tosi <[email protected]> Signed-off-by: Eder Ignatowicz <[email protected]> Co-authored-by: Eder Ignatowicz <[email protected]> Signed-off-by: Adam Maly <[email protected]>
4 participants
Fixes #530
Demo uploaded with voiceover