-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved container and host policy fuzzer #1891
base: main
Are you sure you want to change the base?
Conversation
FuzzHostPolicy still needs to be updated based on the review. @daemon1024 would love your reviews here |
Inside FuzzContainerPolicy, I've added a new case :
This also solved the error we were getting earlier with this value :
There are a few more cases where fuzzer throws
What do you think of these conditions? |
@prady0t Can you share more on why it is hard? Is it because it's not possible to add a new label through them or have the enforcer based check? |
Yes because it's hard for fuzzer to generate such conditions. We can still add this condition inside fuzzer if we want |
I think it should be fine. Ideally these should be handled by policy validation. |
Please rebase @prady0t. |
Signed-off-by: prady0t <[email protected]>
Signed-off-by: prady0t <[email protected]>
6750842
to
a29abc5
Compare
Purpose of PR?:
Fixing bugs in fuzzers.
Seed value changed from yaml to json for checking for generation of invalid json inputs.
ContainerPolicy
andHostPolicy
now returns err for generated errors.