Add option for docker imagepull secrets

In larger production environments, we may get rate-limited by Docker Hub for a lot of image pulls. So, I've added an option for providing the Docker pull secret name to avoid rate limits. Signed-off-by: Jana [email protected]
kubearmor · Jul 15, 2024 · 1a6e8ba · 1a6e8ba
1 parent a5f584c
commit 1a6e8ba
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/deployments/helm/KubeArmor/templates/daemonset.yaml b/deployments/helm/KubeArmor/templates/daemonset.yaml
@@ -16,6 +16,10 @@ spec:
       labels:
         kubearmor-app: kubearmor
     spec:
+      {{- if .Values.kubearmor.image.imagePullSecrets }}
+      imagePullSecrets:
+      {{ toYaml .Values.kubearmor.image.imagePullSecrets | indent 6 }}
+      {{- end }}
       containers:
       - args:
         - -gRPC=32767
@@ -83,6 +87,10 @@ spec:
       initContainers:
       - image: {{printf "%s:%s" .Values.kubearmorInit.image.repository .Values.kubearmorInit.image.tag}}
         imagePullPolicy: {{ .Values.kubearmorInit.imagePullPolicy }}
+      {{- if .Values.kubearmorInit.image.imagePullSecrets }}
+        imagePullSecrets:
+      {{ toYaml .Values.kubearmorInit.image.imagePullSecrets | indent 9 }}
+      {{- end }}
         name: init
         securityContext:
           capabilities:

diff --git a/deployments/helm/KubeArmor/templates/deployment.yaml b/deployments/helm/KubeArmor/templates/deployment.yaml
@@ -18,6 +18,10 @@ spec:
       labels:
         kubearmor-app: kubearmor-relay
     spec:
+      {{- if .Values.kubearmorRelay.image.imagePullSecrets }}
+      imagePullSecrets:
+      {{ toYaml .Values.kubearmorRelay.image.imagePullSecrets | indent 6 }}
+      {{- end }}
       containers:
       - args:
         {{printf "- -tlsEnabled=%t" .Values.tls.enabled}}
@@ -79,6 +83,10 @@ spec:
         - /manager
         image: {{printf "%s:%s" .Values.kubearmorController.image.repository .Values.kubearmorController.image.tag}}
         imagePullPolicy: {{ .Values.kubearmorController.imagePullPolicy }}
+      {{- if .Values.kubearmorController.image.imagePullSecrets }}
+        imagePullSecrets:
+      {{ toYaml .Values.kubearmorController.image.imagePullSecrets | indent 8 }}
+      {{- end }}
         livenessProbe:
           httpGet:
             path: /healthz
@@ -117,6 +125,10 @@ spec:
         - --logtostderr=true
         - --v=0
         image: {{printf "%s:%s" .Values.kubeRbacProxy.image.repository .Values.kubeRbacProxy.image.tag}}
+      {{- if .Values.kubeRbacProxy.image.imagePullSecrets }}
+        imagePullSecrets:
+      {{ toYaml .Values.kubeRbacProxy.image.imagePullSecrets | indent 8 }}
+      {{- end }}
         name: kube-rbac-proxy
         ports:
         - containerPort: 8443

diff --git a/deployments/helm/KubeArmor/values.yaml b/deployments/helm/KubeArmor/values.yaml
@@ -16,8 +16,11 @@ kubearmorRelay:
     repository: kubearmor/kubearmor-relay-server
     # kubearmor-init image tag
     tag: latest
+    # Optional, but if there are a lot of image pulls required, Docker might be rate-limited. So, it's good to add pull secrets for production.
+    imagePullSecrets: ""
   # kubearmor-init imagePullPolicy
   imagePullPolicy: Always
+
   # Add environment variables for STDOUT logging
   enableStdoutLogs: "false"
   enableStdoutAlerts: "false"
@@ -62,6 +65,8 @@ kubearmorInit:
     repository: kubearmor/kubearmor-init
     # kubearmor-init image tag
     tag: stable
+    # Optional, but if there are a lot of image pulls required, Docker might be rate-limited. So, it's good to add pull secrets for production.
+    imagePullSecrets: ""
   # kubearmor-init imagePullPolicy
   imagePullPolicy: Always
 
@@ -71,6 +76,8 @@ kubeRbacProxy:
     repository: gcr.io/kubebuilder/kube-rbac-proxy
     # kube-rbac-proxy image tag
     tag: v0.15.0
+    # Optional, but if there are a lot of image pulls required, Docker might be rate-limited. So, it's good to add pull secrets for production.
+    imagePullSecrets: ""
   # kube-rbac-proxy imagePullPolicy
   imagePullPolicy: Always
 
@@ -83,6 +90,8 @@ kubearmorController:
     repository: kubearmor/kubearmor-controller
     # kubearmor-controller image tag
     tag: latest
+    # Optional, but if there are a lot of image pulls required, Docker might be rate-limited. So, it's good to add pull secrets for production.
+    imagePullSecrets: ""
   mutation:
     # kubearmor-controller failure policy
     failurePolicy: Ignore
@@ -102,7 +111,8 @@ kubearmor:
     repository: kubearmor/kubearmor
     # kubearmor daemonset image tag
     tag: stable
-
+    # Optional, but if there are a lot of image pulls required, Docker might be rate-limited. So, it's good to add pull secrets for production.
+    imagePullSecrets: ""
   # kubearmor daemonset imagePullPolicy
   imagePullPolicy: Always