Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version gate crd method with selectable fields #1609

Closed
wants to merge 1 commit into from

Conversation

clux
Copy link
Member

@clux clux commented Oct 18, 2024

Adds a if ge_1_30 macro to the fn with fields
and duplicates it for le_1_29 without the fields

Adds a if ge_1_30 macro to the fn with fields
and duplicates it for le_1_29 without the fields

Signed-off-by: clux <[email protected]>
@clux clux added the changelog-fix changelog fix category for prs label Oct 18, 2024
@clux clux added this to the 0.97.0 milestone Oct 18, 2024
@clux clux marked this pull request as ready for review October 18, 2024 10:11
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (1addf43) to head (7e17967).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1609   +/-   ##
=====================================
  Coverage   75.3%   75.3%           
=====================================
  Files         82      82           
  Lines       7340    7340           
=====================================
  Hits        5524    5524           
  Misses      1816    1816           
Files with missing lines Coverage Δ
kube-derive/src/custom_resource.rs 81.2% <ø> (ø)

@clux clux removed this from the 0.97.0 milestone Oct 18, 2024
@clux clux closed this Oct 18, 2024
@clux clux deleted the version-gate-crd-method branch October 18, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant