Skip to content
This repository has been archived by the owner on Nov 15, 2024. It is now read-only.

refactor: force UUID on IdentifiableError constructor #52

Merged
merged 19 commits into from
Aug 17, 2024

Conversation

KisaragiEffective
Copy link
Member

What

close #50

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@KisaragiEffective
Copy link
Member Author

SPDXのエラー → このPRに先行するPRで解決予定
lint → namespace を module にするだけ

@KisaragiEffective KisaragiEffective marked this pull request as draft August 6, 2024 17:44
@KisaragiEffective

This comment was marked as resolved.

@KisaragiEffective

This comment was marked as resolved.

@KisaragiEffective

This comment was marked as resolved.

@KisaragiEffective
Copy link
Member Author

@KisaragiEffective
Copy link
Member Author

related: #56

@KisaragiEffective
Copy link
Member Author

そういえば、IdentifiableErrorのUUIDは全て小文字なので小文字のみ許可するようにしたほうがいいかもしれない

@KisaragiEffective KisaragiEffective marked this pull request as ready for review August 16, 2024 23:51
@KisaragiEffective KisaragiEffective merged commit 415562b into fork Aug 17, 2024
19 checks passed
@KisaragiEffective KisaragiEffective deleted the force-uuid branch August 17, 2024 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdentifiableErrorのエラー番号を「内包的型境界」を用いてUUIDであることを強制する
1 participant