Adding in rudimentary benchmark system #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am tempted to just land this because I’m so glad you’re on board, but I’m going to provide style feedback anyway so I can communicate how you can save me some time in the future. |
| var drain = require("./drain"); | ||
| var benchmark = require("./scaffold"); | ||
|
|
||
| benchmark.run(); |
There was a problem hiding this comment.
If we call this file index.js, we can run node benchmarks to execute them all.
|
Okay, I fixed the issues you brought up. |
|
Looks like CI broke. I’ll have to swing back and fix that. |
kriskowal
added a commit
that referenced
this pull request
Jun 1, 2015
Adding in rudimentary benchmark system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #59, this is the first step in improving the performance of the queue implementation.