Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

补充js和ts对应的哈希查找 #187

Merged
merged 12 commits into from
Jan 11, 2023
Merged

补充js和ts对应的哈希查找 #187

merged 12 commits into from
Jan 11, 2023

Conversation

zhuoqinyue
Copy link
Contributor

If this PR is related to coding or code translation, please fill out the checklist.

  • I've tested the code and ensured the outputs are the same as the outputs of reference codes.
  • I've checked the codes (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

@vercel
Copy link

vercel bot commented Dec 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
hello-algo ⬜️ Ignored (Inspect) Jan 11, 2023 at 11:26AM (UTC)

@zhuoqinyue zhuoqinyue mentioned this pull request Dec 29, 2022
Closed
3 tasks
@krahets krahets added the code Code-related label Jan 2, 2023
@zhuoqinyue
Copy link
Contributor Author

Hey, I've translated this method.

krahets
krahets reviewed Jan 8, 2023
View reviewed changes
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please address the comments.

Wait for the final review by @justin-tse .

@zhuoqinyue
Copy link
Contributor Author

OK. I've fixed all.
Then I have a suggestion that you can clarify the code style in chapter_preface as far as possible.

@krahets
Copy link
Owner

krahets commented Jan 8, 2023

OK. I've fixed all. Then I have a suggestion that you can clarify the code style in chapter_preface as far as possible.

Got it.

justin-tse
justin-tse approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@justin-tse justin-tse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zhuoqinyue for your clear code. It looks good and only has a small flaw.

codes/typescript/chapter_searching/hashing_search.ts Outdated Show resolved Hide resolved
codes/typescript/chapter_searching/hashing_search.ts Outdated Show resolved Hide resolved
docs/chapter_searching/hashing_search.md Outdated Show resolved Hide resolved
docs/chapter_searching/hashing_search.md Outdated Show resolved Hide resolved
This was referenced Jan 11, 2023
Closed
Closed
@zhuoqinyue
Copy link
Contributor Author

Hey, I've fixed all.
And should I do something in PR #121 and #120? @justin-tse
I will translate the Deque after this PR finish

@justin-tse
Copy link
Contributor

justin-tse commented Jan 11, 2023 •
edited
Loading

@zhuoqinyueThank you! Of course! I have assigned the task of Deque to you.

zhuoqinyue
zhuoqinyue commented Jan 11, 2023
View reviewed changes
Copy link
Contributor Author

@zhuoqinyue zhuoqinyue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question.
How could I close this?
image
@krahets

@krahets
Copy link
Owner

krahets commented Jan 11, 2023 •
edited
Loading

I have a question. How could I close this? image @krahets

Hi! You don't have to do it. The PR will be merged soon once approved by @justin-tse.

@krahets krahets merged commit 8f66b02 into krahets:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krahets krahets krahets approved these changes

@justin-tse justin-tse justin-tse approved these changes

Assignees
No one assigned
Labels
code Code-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhuoqinyue @krahets @justin-tse