Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#118] Use named parameters in database queries #128

Merged
merged 2 commits into from
Jul 21, 2019
Merged

[#118] Use named parameters in database queries #128

merged 2 commits into from
Jul 21, 2019

Conversation

rashadg1030
Copy link
Collaborator

Resolves #118

@rashadg1030 rashadg1030 added refactoring Code refactoring and prettyfying db Database queries, requests, issues labels Jul 21, 2019
@rashadg1030 rashadg1030 requested review from chshersh and vrom911 July 21, 2019 06:40
@rashadg1030 rashadg1030 self-assigned this Jul 21, 2019
vrom911
vrom911 approved these changes Jul 21, 2019
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! I'm sure that named parameters would be helpful for us 👍

chshersh
chshersh approved these changes Jul 21, 2019
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@chshersh chshersh merged commit 2eae75b into master Jul 21, 2019
@chshersh chshersh deleted the rashadg1030/118-Consider-using-named-parameters-in branch July 21, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

@chshersh chshersh chshersh approved these changes

Assignees

@rashadg1030 rashadg1030

Labels
db Database queries, requests, issues refactoring Code refactoring and prettyfying
Projects
None yet
Milestone
Tech Debt: No issues wanted
Development

Successfully merging this pull request may close these issues.

Consider using named parameters in queries
3 participants
@rashadg1030 @chshersh @vrom911