Skip to content

Conversation

@koushiro
Copy link
Owner

@koushiro koushiro commented Apr 6, 2025

No description provided.

@koushiro koushiro requested a review from Copilot April 6, 2025 04:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

client/src/metrics/raw/quantile.rs:10

  • The removal of PartialEq from the Quantile struct may cause issues if equality checks are used elsewhere. Please verify that this change is intentional and update all affected usages accordingly.
#[derive(Copy, Clone, Debug)]

client/src/metrics/raw/bucket.rs:23

  • Removing PartialEq from the Bucket struct could lead to breaking equality comparisons where they are required. Ensure this change was intended and update any dependent code as needed.
#[derive(Copy, Clone, Debug)]

@koushiro koushiro merged commit c4a823e into main Apr 6, 2025
9 checks passed
@koushiro koushiro deleted the add-benchmark-results branch April 6, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants