Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ISSUE_TEMPLATE #25

Merged
merged 1 commit into from
Sep 8, 2023
Merged

add ISSUE_TEMPLATE #25

merged 1 commit into from
Sep 8, 2023

Conversation

kuangcheng66
Copy link
Contributor

  1. bug-report.md
  2. enhancement.md
  3. flaking-test.md
  4. good-first.md
  5. question.md

@kuangcheng66
Copy link
Contributor Author

/assign @duanmengkk

@duanmengkk
Copy link
Contributor

/lgtm don't have to follow Karmada's template necessarily , you can also just go with the Kubernetes template

@duanmengkk
Copy link
Contributor

/lgtm

<!-- Please use this template while asking a new question. Thanks!
Please make sure you have read the FAQ and searched the issue list.
- FAQ: https://github.com/Kosmos-io/Kosmos/blob/master/docs/frequently-asked-questions.md
- Issues: https://github.com/Kosmos-io/Kosmos/issues?q=is%3Aissue+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I will update it as soon as possible

@wuyingjun-lucky
Copy link
Member

@kuangcheng66 Should we be going on this pr?

@kosmos-robot kosmos-robot removed the lgtm label Sep 7, 2023
@duanmengkk
Copy link
Contributor

you can use rebase to squash the commit

@wuyingjun-lucky
Copy link
Member

/approve

@wuyingjun-lucky
Copy link
Member

wuyingjun-lucky commented Sep 7, 2023

@kuangcheng66 you can rebase the commits to avoid the upstream merge commits

@wuyingjun-lucky
Copy link
Member

/approve cancel

@duanmengkk
Copy link
Contributor

/ok-to-test

@kuangcheng66
Copy link
Contributor Author

ok

Signed-off-by: kuangcheng <[email protected]>
@kosmos-robot
Copy link
Contributor

@kuangcheng66: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kuangcheng66
Copy link
Contributor Author

@duanmengkk
Copy link
Contributor

/lgtm

@wuyingjun-lucky
Copy link
Member

/approve

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuyingjun-lucky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kosmos-robot kosmos-robot merged commit 2ab4d5b into kosmos-io:main Sep 8, 2023
4 checks passed
wangyizhi1 pushed a commit to wangyizhi1/kosmos that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants