koordetector: make koordetector run and compatible with different kernels #34
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…nels Signed-off-by: songtao98 <songtao2603060@gmail.com>
songtao98
force-pushed
the
make_koordetector_run
branch
from
cf7cf34 to
8f239d9
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 33.70% 33.70%
=======================================
Files 1 1
Lines 89 89
=======================================
Hits 30 30
Misses 58 58
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| statesInformerConf := statesinformer.NewDefaultConfig() | ||
|
|
||
| statesInformer := statesinformer.NewStatesInformer(statesInformerConf, kubeClient, nodeName) | ||
| statesInformer := statesinformer.NewStatesInformer(config.StatesInformerConf, kubeClient, nodeName) |
There was a problem hiding this comment.
now we can consider import statesinformer pkg from koordlet directly?
| context *framework.Context | ||
| } | ||
|
|
||
| func NewMetricAdvisor(cfg *framework.Config, statesInformer statesinformer.StatesInformer) MetricAdvisor { |
There was a problem hiding this comment.
use the MetricAdvisor from koordlet?
2 participants
Ⅰ. Describe what this PR does
This PR completes codes for koordetector to run with Dockerfile. The functionality of CPU schedule latency eBPF program is now available by this commit.
An eBPF CO-RE way is used to develop CSL collector. For developers' intention, you can follow belowing process to develop a eBPF program under koordetector's architecture:
.cfile. (e.g.pkg/koordetector/util/ebpf/cpu_schedule_latency/csl.bpf.c)"github.com/cilium/ebpf"package and provide a go util(e.g.pkg/koordetector/util/cpu_schedule_latency/cpu_schedule_latency.go).go generateto compile and generate.ofile for your eBPF program. Files inpkg/koordetector/util/ebpf/headerscan be used for that./sys/kernel/btf/vmlinux) file to re-location kernel information such astask_structstructure. If this fails (e.g. kernel < 5.2 does not has vmlinux in /sys/kernel/btf/vmlinux), the CSL collector will use vmlinux files inpkg/koordetector/util/ebpf/core.For now, I added supporting vmlinux file of kernel
vmlinux-4.19.91-27.4.al7.x86_64in this PR. Vmlinux files for other kernels can be find in BTFhub, Anolis coolbpf or generate by pahole.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test