fix warning

kookxiang · Aug 28, 2024 · d8b09f6 · d8b09f6
1 parent ddaeadf
commit d8b09f6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/Jellyfin.Plugin.Bangumi/Providers/MusicSongProvider.cs b/Jellyfin.Plugin.Bangumi/Providers/MusicSongProvider.cs
@@ -69,7 +69,7 @@ public async Task<HttpResponseMessage> GetImageResponse(string url, Cancellation
         if (string.IsNullOrEmpty(fileName))
             return null;
 
-        var album = libraryManager.FindByPath(info.Path, false).FindParent<MusicAlbum>();
+        var album = libraryManager.FindByPath(info.Path, false)?.FindParent<MusicAlbum>();
         if (album is null)
             return null;
 

diff --git a/Jellyfin.Plugin.Bangumi/ScheduledTask/RatingRefreshTask.cs b/Jellyfin.Plugin.Bangumi/ScheduledTask/RatingRefreshTask.cs
@@ -59,6 +59,7 @@ public async Task ExecuteAsync(IProgress<double> progress, CancellationToken tok
 
             // obtain library item
             var item = library.GetItemById(id);
+            if (item == null) continue;
 
             // skip item if it was refreshed recently 
 #if EMBY

diff --git a/Jellyfin.Plugin.Bangumi/ScheduledTask/TokenRefreshTask.cs b/Jellyfin.Plugin.Bangumi/ScheduledTask/TokenRefreshTask.cs
@@ -1,22 +1,20 @@
-
+#if EMBY
+using MediaBrowser.Model.Logging;
+#else
+using Microsoft.Extensions.Logging;
+using Jellyfin.Data.Entities;
+#endif
 using System;
 using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
 using Jellyfin.Plugin.Bangumi.OAuth;
-using MediaBrowser.Controller.Library;
 using MediaBrowser.Model.Activity;
 using MediaBrowser.Model.Tasks;
-#if EMBY
-using MediaBrowser.Model.Logging;
-#else
-using Microsoft.Extensions.Logging;
-using Jellyfin.Data.Entities;
-#endif
 
 namespace Jellyfin.Plugin.Bangumi.ScheduledTask;
 
-public class TokenRefreshTask(IUserManager userManager, IActivityManager activity, BangumiApi api, OAuthStore store)
+public class TokenRefreshTask(IActivityManager activity, BangumiApi api, OAuthStore store)
     : IScheduledTask
 {
     public string Key => "OAuthTokenRefreshTask";
@@ -55,7 +53,6 @@ public async Task ExecuteAsync(IProgress<double> progress, CancellationToken tok
         var total = users.Count;
         foreach (var (guid, user) in users)
         {
-            var userId = Guid.Parse(guid);
             token.ThrowIfCancellationRequested();
             progress.Report(current / total);
             current++;
@@ -83,6 +80,7 @@ public async Task ExecuteAsync(IProgress<double> progress, CancellationToken tok
 
             activity.Create(activityLogEntry);
 #else
+            var userId = Guid.Parse(guid);
             var activityLog = new ActivityLog("Bangumi 授权", "Bangumi", userId);
             try
             {