Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Set filenames for task details downloads #2031

Merged
merged 1 commit into from
Jul 25, 2024

Commits on Jul 25, 2024

  1. 🐛 Set filenames for task details downloads

    On the Analysis details / Task details page, the log
    viewer allows downloading of the file being displayed.
    Set a filename that matches the attachment name when
    doing the download.
    
    File names used:
      - Base log view -> "log-${taskId}"
      - Merged log view -> "log-merged-${taskId}"
      - Task attachment -> attachment name
    
    Due to the way the `CodeEditor` PF5 component implements
    the download action, only file extensions of known file
    types can be used.  Any log or attachment files will have
    file extensions of `.yaml` or `.json` or `.txt` depending
    on the detected file type.  File type detection is only
    using attachment name file extensions currently, and only
    differentiates between yaml and json with a default to plain
    text.  For example, given an attachment name, the download
    file name will be:
      - `git.output` -> `git.output.txt`
      - `addon.log` -> `addon.log.txt`
      - `settings.yaml` -> `settings.yaml`
      - `data.json` -> `data.json`
    
    Signed-off-by: Scott J Dickerson <[email protected]>
    sjd78 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5c9bced View commit details
    Browse the repository at this point in the history