Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix field alignment on the Repositories>Maven page #2029

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Jul 25, 2024

The info text box and the "Clear repository" button is now aligned horizontally and above the switch.

Resolves: https://issues.redhat.com/browse/MTA-3149

@sjd78
Copy link
Member Author

sjd78 commented Jul 25, 2024

Before:
screenshot-192 168 39 173-2024 07 24-22_25_11

After:
screenshot-localhost_9000-2024 07 24-22_26_03

@sjd78 sjd78 added this to the v0.5.0 milestone Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.15%. Comparing base (b654645) to head (122edbf).
Report is 201 commits behind head on main.

Files Patch % Lines
client/src/app/pages/repositories/Mvn.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2029      +/-   ##
==========================================
+ Coverage   39.20%   42.15%   +2.95%     
==========================================
  Files         146      171      +25     
  Lines        4857     5503     +646     
  Branches     1164     1305     +141     
==========================================
+ Hits         1904     2320     +416     
- Misses       2939     3167     +228     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.15% <0.00%> (+2.95%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The info text box and the "Clear repository" button
is now aligned horizontally and above the switch.

Resolves: https://issues.redhat.com/browse/MTA-3149

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 force-pushed the repo-maven-field-alignment branch from 2c7fc52 to 122edbf Compare July 25, 2024 13:22
@sjd78 sjd78 merged commit 1c5e994 into konveyor:main Jul 25, 2024
12 checks passed
@sjd78 sjd78 deleted the repo-maven-field-alignment branch August 5, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants