✨ Add handling for tasks "Succeeded with errors" in task and application tables #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
+ Coverage 39.20% 42.11% +2.90%
==========================================
Files 146 171 +25
Lines 4857 5488 +631
Branches 1164 1311 +147
==========================================
+ Hits 1904 2311 +407
- Misses 2939 3161 +222
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
changed the title
sjd78
force-pushed
the
success_with_error
branch
2 times, most recently
from
bae5883
to
0f04a08
Compare
sjd78
changed the title
ibolton336
approved these changes
Jul 16, 2024
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Also refactor some components to: - push data access closer to where it is used - break into smaller manageable components Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
success_with_error
branch
from
f578a4a
to
849a2ec
Compare
Signed-off-by: Scott J Dickerson <[email protected]>
This was referenced Jul 17, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #1997
When a task is succeeded but has attached errors, render task state, application tasks state and application analysis state with a warning.
Details of Changes
With this change, hub is not adding a new terminal state, but having a new terminal state is an easy way to handle things. The task queries will now evaluate the
stateanderrorsprops to determine if "Succeeded" should be "SucceededWithErrors". This synthetic task status makes updating all of the UI component much simpler.To function properly, HUB Issue 725 / PR 720 are required.
Changes have also been made to utilize the
/tasks/reports/dashboardendpoint to get a much smaller view of tasks when dealing with them in aggregate.The application details drawer was refactored to push data fetching closer to actual use, and to break up a very large component into a container component with a component dedicated to each tab.
Screenshots
Application inventory page:
Application tasks popover:
Task Manager page:
