Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Link java dependencies that don't have a sha #1983

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Jun 25, 2024

Resolves: #1982

In some analysis cases, java dependencies may be generated with the full name (group id + artifact id) and version but lack a sha value. When this occurs, a maven central search string can still be created.

Now, for any java dependency, link to maven central:

  • Use the dependency's sha, or
  • Use the name and version

Resolves: konveyor#1982

In some analysis cases, java dependencies may be generated
with the full `name` (group id + artifact id) and `version` but
lack a `sha` value.  When this occurs, a maven central search
string can still be created.

Now, for any java dependency, link to maven central:
  - Use the dependencies `sha`, or
  - Use the `name` and `version`

Signed-off-by: Scott J Dickerson <[email protected]>
Copy link

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sjd78 sjd78 requested a review from rszwajko June 25, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dependency links to maven central can be generated if the sha is missing
3 participants