🐛 Add task detail links to tasks page #1980
Conversation
Details screen available via link and action
Task details - log view
Task details - attachment view
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1980 +/- ##
==========================================
+ Coverage 39.20% 42.23% +3.02%
==========================================
Files 146 170 +24
Lines 4857 5451 +594
Branches 1164 1364 +200
==========================================
+ Hits 1904 2302 +398
- Misses 2939 3032 +93
- Partials 14 117 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
What looks good?
- code changes look good
- navigation from the table looks good
- URLs look good
- attached files and merged views look good
Breadcrumbs
What about having them include the "Task ${task.id}" text included? So for a given URL like "/tasks/7" they look like:
Title
The title shows the name of the task. That is not enough to positively identify the task. If you create an application "Bear" w/o sources initially, and then edit it to include sources, there will be multiple tasks named "Bear-language-discovery".
Maybe a title more like:
"Task details for task ${task.id}, ${task.name}"
|
@sjd78
On Analysis details screen situation is a bit different - we used "fake" application page (main table with details drawer opened). There "Analysis details" is the current page. |
1. extract base component to re-use for Analysis Details and Task Details 2. add 2 new routes: a) /tasks/:taskId b) /tasks/:taskId/attachments/:attachmentId 3. user can enter details screen by: a) task status name (link) b) "Task details" action (per row kebab actions" Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
force-pushed
the
linkToDetails
branch
2 times, most recently
from
46cb9b9
to
63af805
Compare
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
|
@sjd78 |
Fix regression after: #1980 Resolves: https://issues.redhat.com/browse/MTA-1390 Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state). Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters. Reference-Url: #1698 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Fix regression after: konveyor#1980 Resolves: https://issues.redhat.com/browse/MTA-1390 Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state). Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters. Reference-Url: konveyor#1698 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
#2033) (#2038) Backport-of: (#2033) Fix regression after: #1980 Resolves: https://issues.redhat.com/browse/MTA-1390 Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state). Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters. Reference-Url: #1698 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
a) /tasks/:taskId
b) /tasks/:taskId/attachments/:attachmentId
a) task status name (link)
b) "Task details" action (per row kebab actions)
and Task Manager pages to fix problems with returning
from task details page.
Resolves: #1975