🐛 Disabling useFetchCache query if RWX_SUPPORTED=false

[mguetta1]

Resolves: https://issues.redhat.com/browse/MTA-3699

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (b654645) to head (ee7c7a2).
Report is 241 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   39.20%   41.98%   +2.78%     
==========================================
  Files         146      175      +29     
  Lines        4857     5630     +773     
  Branches     1164     1409     +245     
==========================================
+ Hits         1904     2364     +460     
- Misses       2939     3145     +206     
- Partials       14      121     +107     

Flag	Coverage Δ
client	41.98% <100.00%> (+2.78%)	⬆️
server	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sjd78]

@mguetta1 - Can you provide some context for this change? Is there an issue or ticket for this? At face value it looks ok, but I'm not sure how the isRWXSupported flag is meant to interact with the loading spinner.

[mguetta1]

@mguetta1 - Can you provide some context for this change? Is there an issue or ticket for this? At face value it looks ok, but I'm not sure how the isRWXSupported flag is meant to interact with the loading spinner.

Hi @sjd78, @dymurray
I just opened a Jira ticket for this issue: https://issues.redhat.com/browse/MTA-3699

[rszwajko]

The loading state seems the consequence of the query being active. IMHO if the entire feature is disabled we should disable the query as well.
React query uses enable flag for this purpose. We use in several places i.e. here.

[mguetta1]

The loading state seems the consequence of the query being active. IMHO if the entire feature is disabled we should disable the query as well. React query uses enable flag for this purpose. We use in several places i.e. here.

Done in ee7c7a2
@rszwajko better to pass isRWXSupported as an argument? I saw that useFetchCache is used only in client/src/app/pages/repositories/Mvn.tsx

[rszwajko]

LGTM! If there will be another use case for useFetchCache then we can always refactor.

[rszwajko]

@mguetta1 please edit the title to better reflect the fix.