-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ View files task attachments #1954
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
==========================================
+ Coverage 39.20% 42.65% +3.45%
==========================================
Files 146 166 +20
Lines 4857 5284 +427
Branches 1164 1269 +105
==========================================
+ Hits 1904 2254 +350
- Misses 2939 3014 +75
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
91c8671
to
124c843
Compare
124c843
to
e4b6895
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX changes:
-
The attachment select drop down background should be white instead of the default transparent --- or maybe the page's content background color white (the other pages do this, see the comment on
AnalysisDetails.tsx
) -
When a file has a known file type (e.g.
settings.yaml
), select that file type for display by default instead of the "Text" one
Looks really good. I have a few comments.
client/src/app/components/simple-document-viewer/SimpleDocumentViewer.tsx
Outdated
Show resolved
Hide resolved
client/src/app/components/simple-document-viewer/SimpleDocumentViewer.tsx
Show resolved
Hide resolved
client/src/app/components/simple-document-viewer/SimpleDocumentViewer.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/applications/analysis-details/AnalysisDetails.tsx
Outdated
Show resolved
Hide resolved
e4b6895
to
299630a
Compare
Resolves: konveyor#1929 Functional changes: 1. document to be viewed is selected from the list (first action above the editor) or via URL 2. display language toggle based on languages supported by the document. For attachments the list consists of plain text and optionally a second language discovered based on file extension (YAML or JSON). 3. replace "merged" checkbox with an option in the select Related refactorings: 1. split getTaskById() query into specialized queries: a) getTaskById() returning Promise<Task> for working with the object b) getTaskByIdAndFormat() returning Promise<string> for displaying the task as a formatted text 2. configure AnalysisDetails component to respond to 2 routes: existing details route and newly added /applications/:applicationId/analysis-details/:taskId/attachments/:attachmentId 3. persist merge mode in the URL as search param "merged" Signed-off-by: Radoslaw Szwajkowski <[email protected]>
299630a
to
0cd4e2d
Compare
@jortel @JustinXHale @rromannissen |
would the default view be the Log View? I dont have any objections. |
yes |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Resolves: #1929
Functional changes:
the editor) or via URL
For attachments the list consists of plain text and optionally a
second language discovered based on file extension (YAML or JSON).
Related refactorings:
a) getTaskById() returning Promise for working with the object
b) getTaskByIdAndFormat() returning Promise for displaying
the task as a formatted text
details route and newly added /applications/:applicationId/analysis-details/:taskId/attachments/:attachmentId