-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix effort width & visibility conditional removed in app table #1947
Conversation
Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
fb52c83
to
9902de6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1947 +/- ##
==========================================
+ Coverage 39.20% 42.16% +2.96%
==========================================
Files 146 166 +20
Lines 4857 5320 +463
Branches 1164 1330 +166
==========================================
+ Hits 1904 2243 +339
- Misses 2939 3061 +122
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The tooltip render is consistent with PF table styling: https://www.patternfly.org/components/table#sortable--wrapping-headers
Noticed some odd behavior in the app table.
Width and column visibility conditional removed from the effort col here:
https://github.com/konveyor/tackle2-ui/pull/1846/files#diff-7215462f9c61fbbe2362b5f02a64aa2f56a9b6b47fab387f8a7e9c5819c92a8eL848
Before:
After:
This PR fixes these regressions in the app table and replaces custom tooltips with the tooltip behavior included within the component via the info prop.