Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix effort width & visibility conditional removed in app table #1947

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Jun 7, 2024

Noticed some odd behavior in the app table.

Width and column visibility conditional removed from the effort col here:
https://github.com/konveyor/tackle2-ui/pull/1846/files#diff-7215462f9c61fbbe2362b5f02a64aa2f56a9b6b47fab387f8a7e9c5819c92a8eL848

Before:

image

After:

Screenshot 2024-06-07 at 10 58 22 AM

This PR fixes these regressions in the app table and replaces custom tooltips with the tooltip behavior included within the component via the info prop.

@ibolton336 ibolton336 changed the title 🐛 Effort width inadvertently removed in app table 🐛 Fix effort width & visibility conditional removed in app table Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.16%. Comparing base (b654645) to head (1fc683a).
Report is 157 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
+ Coverage   39.20%   42.16%   +2.96%     
==========================================
  Files         146      166      +20     
  Lines        4857     5320     +463     
  Branches     1164     1330     +166     
==========================================
+ Hits         1904     2243     +339     
- Misses       2939     3061     +122     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.16% <ø> (+2.96%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The tooltip render is consistent with PF table styling: https://www.patternfly.org/components/table#sortable--wrapping-headers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 'Effort' column displayed even when it's unchecked in the 'Manage columns' modal
3 participants