Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Persist activeItem in URL on the Applications screen #1939

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Jun 5, 2024

Main use case is providing a link to the application drawer.

Part-of: #1929

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.17%. Comparing base (b654645) to head (f88a813).
Report is 153 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1939      +/-   ##
==========================================
+ Coverage   39.20%   42.17%   +2.97%     
==========================================
  Files         146      166      +20     
  Lines        4857     5318     +461     
  Branches     1164     1329     +165     
==========================================
+ Hits         1904     2243     +339     
- Misses       2939     3059     +120     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.17% <ø> (+2.97%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rszwajko rszwajko changed the title ✨ Link to drawer ✨ Persist activeItem in URL on the Applications screen Jun 5, 2024
@rszwajko rszwajko requested review from ibolton336 and sjd78 June 5, 2024 11:19
@sjd78 sjd78 added this to the v0.5.0 milestone Jun 6, 2024
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the changes from #1930 in the first commit, looking at just commit 764de35, looks good.

The only minor thing is if once on the log viewer page, if the application name should be a link so a click on it will work just like the browser back. That can be adjusted in a follow up.

Main use case is  providing a link to the application drawer.

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants