Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 On Issues>Affected Application table, update column data-label to match displayed text #1933

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Jun 3, 2024

Resolves: #1936
UI Tests PR: 1124
Addresses mismatch between data column and displayed text for "Effort" Column in affected applications table

PR #1846 intended to revert back to using effort favoring tooltips to differentiate what is being displayed in fields labeled effort. The Issues>Affected Application table effort column heading text was updated, but the data-label used was still "Total Effort".

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.10%. Comparing base (b654645) to head (95220f7).
Report is 148 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1933      +/-   ##
==========================================
+ Coverage   39.20%   42.10%   +2.90%     
==========================================
  Files         146      163      +17     
  Lines        4857     5235     +378     
  Branches     1164     1326     +162     
==========================================
+ Hits         1904     2204     +300     
+ Misses       2939     2914      -25     
- Partials       14      117     +103     
Flag Coverage Δ
client 42.10% <ø> (+2.90%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjd78 sjd78 changed the title 🐛 Update column name to match displayed text 🐛 On Issues>Affected Application table, update column name to match displayed text Jun 4, 2024
@sjd78 sjd78 changed the title 🐛 On Issues>Affected Application table, update column name to match displayed text 🐛 On Issues>Affected Application table, update column data-label to match displayed text Jun 4, 2024
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and with this change, there are no more occurrences of "Total Effort" in the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants